Fix BulkListSerializerObject is not iterable thing #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iterate over anything. Everything seems to work still. Kind of hacky, but better than nasty 500 errors.
|
@liquidpele thanks. I wonder if this can have any negative side-effects. also build failed |
|
No idea, seemed to work for me though. I don't have time to play with it more though, sorry. |
|
I am currently swamped at work however will try to take a look at this next week. |
|
Just an FYI you might want to fix this a better way. I ended up implementing my own multi functionality in a viewset instead of the serializer, so I won't have the ability to help out. As a hint, I noticed I got the same error in my own implementation when I passed an object to the serializer (instead of a list) when I had many=True set for the serializer's definition. Hope that leads you to figuring it out... Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #33 by making the object iterable even though it doesn't actually iterate over anything. Everything seems to work still. Kind of hacky, but better than nasty 500 errors.